Allow name-mangling for the mbedtls_free and mbedtls_calloc functions #276
Conversation
|
@jethrogb Could you have a look at this? |
|
I think this change is probably correct, but could you add a MacOS test in CI? |
I have no experience with Travis CI but I gave it a try. Maybe, I need some help on this, we'll see. |
DrTobe
force-pushed
the
allow-name-mangling
branch
2 times, most recently
from
2da8f9a to
620c8fe
Compare
|
@jethrogb How can I trigger Travis to pick this up? |
|
Apparently closing and re-opening may trigger a build? |
|
Looks to be some issue with our Travis subscription, hold on... |
|
Anything new here? As far as I can see, still no tests have run? |
|
Could you please rebase your PR and move the CI changes from travis CI to GitHub action workflow file at |
|
Haven't heard back from Travis support unfortunately, let me ping them |
DrTobe
force-pushed
the
allow-name-mangling
branch
2 times, most recently
from
da35742 to
41a3d9a
Compare
…ssl_flush_output functions According to the discussion in rust-lang/rust-bindgen#1221 (comment), the \u{1} is a hint to LLVM to avoid name-mangling but this might be required on some platforms to link against the right name, e.g. on macOS.
DrTobe
force-pushed
the
allow-name-mangling
branch
2 times, most recently
from
dca91bd to
4e005ae
Compare
|
Looks like we've got working macOS tests, yay. Just don't make me program that yaml-shell-build.rs-cmake-chain again, please 😆 |
|
Hi @jethrogb ,let's we keep track the issue of Travis CI in
|
Head branch was pushed to by a user without write access
DrTobe
force-pushed
the
allow-name-mangling
branch
from
897e1a2 to
4e005ae
Compare
According to the discussion in rust-lang/rust-bindgen#1221 (comment), the
\u{1}is a hint to LLVM to avoid name-mangling but this might be required on some platforms to link against the right name, e.g. on macOS.So this fixes builds on macOS.
@jethrogb you have been part in that discussion so maybe you can evaluate if this change is the right thing to do or if this will potentially lead to other problems?