Skip to content

Conversation

@Taowyoo
Copy link
Collaborator

@Taowyoo Taowyoo commented Oct 26, 2023

This PR is based on #327
So please only review the commits start from: 697923d

@Taowyoo Taowyoo force-pushed the yx/extend-cipher branch 2 times, most recently from 54738c9 to bc6359c Compare October 26, 2023 18:50
@Taowyoo Taowyoo requested a review from s-arash October 26, 2023 19:54
Add chachapoly as valid ciphermode for Authenticated Cipher.
Add a no compress version import fn:
`from_binary_no_compress`. It seems current way of detect compression is
not always true.
@Taowyoo
Copy link
Collaborator Author

Taowyoo commented Oct 31, 2023

I revert the feat: make Hmac clone-able because the normal clone logic does not work well with Hmac .

@Taowyoo Taowyoo requested a review from s-arash October 31, 2023 18:17
@Taowyoo Taowyoo enabled auto-merge (squash) October 31, 2023 19:30
@Taowyoo Taowyoo merged commit 0a79c87 into main Oct 31, 2023
@Taowyoo Taowyoo deleted the yx/extend-cipher branch October 31, 2023 19:35
@Taowyoo Taowyoo restored the yx/extend-cipher branch October 31, 2023 19:44
@Taowyoo Taowyoo deleted the yx/extend-cipher branch October 31, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants