-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend Cipher types #330
Merged
Merged
Extend Cipher types #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taowyoo
force-pushed
the
yx/extend-cipher
branch
2 times, most recently
from
October 26, 2023 18:50
54738c9
to
bc6359c
Compare
Taowyoo
force-pushed
the
yx/extend-cipher
branch
from
October 26, 2023 22:26
8353ed3
to
8b3c9b5
Compare
Taowyoo
force-pushed
the
yx/extend-cipher
branch
from
October 27, 2023 16:23
8b3c9b5
to
81536e1
Compare
Add chachapoly as valid ciphermode for Authenticated Cipher.
Add a no compress version import fn: `from_binary_no_compress`. It seems current way of detect compression is not always true.
This reverts commit 78af5e2.
I revert the |
s-arash
reviewed
Oct 31, 2023
s-arash
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #327
So please only review the commits start from: 697923d