Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend Cipher types #330

Merged
merged 9 commits into from
Oct 31, 2023
Merged

Extend Cipher types #330

merged 9 commits into from
Oct 31, 2023

Conversation

Taowyoo
Copy link
Collaborator

@Taowyoo Taowyoo commented Oct 26, 2023

This PR is based on #327
So please only review the commits start from: 697923d

Add chachapoly as valid ciphermode for Authenticated Cipher.
Add a no compress version import fn:
`from_binary_no_compress`. It seems current way of detect compression is
not always true.
@Taowyoo
Copy link
Collaborator Author

Taowyoo commented Oct 31, 2023

I revert the feat: make Hmac clone-able because the normal clone logic does not work well with Hmac .

mbedtls/src/cipher/raw/mod.rs Outdated Show resolved Hide resolved
mbedtls/src/cipher/raw/mod.rs Outdated Show resolved Hide resolved
@Taowyoo Taowyoo requested a review from s-arash October 31, 2023 18:17
@Taowyoo Taowyoo enabled auto-merge (squash) October 31, 2023 19:30
mbedtls/src/ecp/mod.rs Show resolved Hide resolved
@Taowyoo Taowyoo merged commit 0a79c87 into main Oct 31, 2023
9 checks passed
@Taowyoo Taowyoo deleted the yx/extend-cipher branch October 31, 2023 19:35
@Taowyoo Taowyoo restored the yx/extend-cipher branch October 31, 2023 19:44
@Taowyoo Taowyoo deleted the yx/extend-cipher branch October 31, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants