Silence unsafe FFI warnings #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The rust compiler is issuing false positive improper_ctypes warning, but this is not an issue because only pointers are being passed to mbedtls, and they are used completely opaquely.
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Nov 12, 2019
82: Silence unsafe FFI warnings r=jack-fortanix a=Goirad The rust compiler is issuing false positive improper_ctypes warning, but this is not an issue because only pointers are being passed to mbedtls, and they are used completely opaquely. Co-authored-by: Dario Gonzalez <dario.gonzalez@fortanix.com>
Build succeeded
|
|
This is fine, but ideally this would be reported upstream so they fix the lint. |
mcr
pushed a commit
to mcr/rust-mbedtls
that referenced
this pull request
Aug 10, 2023
This defines a new trait `Resolver`, which turns an address into a Vec<SocketAddr>. It also provides an implementation of Resolver for `Fn(&str)` so it's easy to define simple resolvers with a closure. Fixes fortanix#82 Co-authored-by: Ulrik <ulrikm@spotify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rust compiler is issuing false positive improper_ctypes warning, but
this is not an issue because only pointers are being passed to mbedtls,
and they are used completely opaquely.