[Check code with CI] aj/update-sgx-alloc #609
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aditijannu
requested review from
arai-fortanix,
raoulstrackx,
nshyrei and
NirjharRoyiitk
1 task
|
The code change here should be moved to fortanix/rust#16 |
snmalloc-edp/build.rs
Outdated
| let sn_alloc_align = sn_alloc_align.expect("sn_alloc_align"); | ||
|
|
||
| let mut get_u64_at_symbol = |sym: elf::symbol::Symbol| { | ||
| assert_eq!(sym.st_size, 8); |
There was a problem hiding this comment.
Minor: is there a constant we can use instead of 8 here? Or is there a Rust equivalent of sizeof uint64_t? This applies for the two uses of a literal 8 two lines down as well.
|
Addressed most of the comments left by @arai-fortanix in the latest commit but the unit test seems to be failing. Once I resolve that issue, I will move snmalloc-edp over to the rust repository. |
aditijannu
force-pushed
the
aj/update-sgx-alloc
branch
from
106b8c3
to
9cf7ed2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Glue code for snmalloc allocator in SGX enclaves.