Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: fcli --version doesn't output anything #112

Closed
rsenden opened this issue Sep 29, 2022 · 3 comments
Closed

Bug: fcli --version doesn't output anything #112

rsenden opened this issue Sep 29, 2022 · 3 comments

Comments

@rsenden
Copy link
Contributor

rsenden commented Sep 29, 2022

Currently fcli --version doesn't output anything; it should output a proper version number.

We should consider a similar approach as for FortifyVulnerabilityExporter, where a version number is generated during pipeline execution (matching the actual version tag for release builds, or based on branch and date/time for non-release builds) and passed to the gradle build, as shown here: https://github.com/fortify/FortifyVulnerabilityExporter/blob/13e2856137507c2384935c885371ea892269b7c3/.github/workflows/ci.yml#L75

The Gradle build should then properly store the provided version number for use by the fcli --version command.

@rsenden rsenden added this to the v1.0 milestone Sep 29, 2022
@rsenden
Copy link
Contributor Author

rsenden commented Sep 30, 2022

Current implementation works for jar version, but not native images

@rsenden rsenden reopened this Sep 30, 2022
rsenden added a commit that referenced this issue Sep 30, 2022
rsenden added a commit that referenced this issue Sep 30, 2022
rsenden added a commit that referenced this issue Sep 30, 2022
rsenden added a commit that referenced this issue Sep 30, 2022
rsenden added a commit that referenced this issue Sep 30, 2022
rsenden added a commit that referenced this issue Sep 30, 2022
rsenden added a commit that referenced this issue Sep 30, 2022
@MikeTheSnowman
Copy link
Collaborator

For some reason, I'm seeing this again with our native binaries for both v1.0 and v1.0.1.
This was reported by QA.

@rsenden
Copy link
Contributor Author

rsenden commented Dec 16, 2022

This issue was reintroduced because we now automatically generate resource-config.json files (required for native binaries) during the Gradle build, based on resource files found in src/main/resources. Since the build properties file is being generated during the build, it wasn't being picked up by the automated resource-config.json generation. I've updated the build properties generation task to also generate a corresponding resource-config.json file.

@github-actions github-actions bot mentioned this issue Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants