Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add []byte as base64 flag type and support direct binary from configmap binaryData section for said type #52

Merged
merged 7 commits into from
Oct 31, 2023

Conversation

ldemailly
Copy link
Member

@ldemailly ldemailly commented Oct 31, 2023

For #51 : the flag as base64 text on cmd line part, auto decoding to binary, and when in a file/configmap allow verbatim (needs to be binaryData key instead of data for a kubernetes configmap)

  • test that a confimap binaryData really ends up as binary once mounted
  • add binary type with base64 for cli and no base64 for cmap
  • special handling in configmap

Copy link

codecov bot commented Oct 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Files Coverage Δ
configmap/updater.go 80.28% <100.00%> (+1.65%) ⬆️
dyngeneric.go 100.00% <100.00%> (ø)

📢 Thoughts on this report? Let us know!.

@ldemailly
Copy link
Member Author

Coverage is actually in the e2e test but not showing...

@ldemailly ldemailly changed the title Add []byte as base64 flag type Add []byte as base64 flag type and support direct binary from configmap binaryData section for said type Oct 31, 2023
@ldemailly ldemailly merged commit 4cfcd24 into main Oct 31, 2023
5 checks passed
@ldemailly ldemailly deleted the binary branch October 31, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant