Added user filter on findDelegation #1184
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removing searchfilter for DCs to allow RBCD and Unconstrained to be shown
Fixing findDelegation.py to include RBCD over DCs
alexisbalbachan
approved these changes
Mar 23, 2023
|
@ShutdownRepo Could you please rebase the code to the latest version of impacket? |
alexisbalbachan
added
the
waiting for response
GeisericII
added a commit
to ThePorgs/impacket
that referenced
this pull request
Aug 8, 2024
fortra#1184 Update findDelegation.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a user filter, just like GetADUsers. This allows for lighter results in huge environments.
I also changed the "Constrained" strings to "Constrained w/o Protocol Transition" because of the "Constrained w/ Protocol Transition" that was already there. Before this, users of the findDelegation script that would not read the code and would only find "Constrained" accounts could wrongly assume that the "Protocol Transition" thing is not checked.