Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dependency in setup.py #1320

Merged
merged 1 commit into from
May 13, 2022
Merged

Add dependency in setup.py #1320

merged 1 commit into from
May 13, 2022

Conversation

ThePirateWhoSmellsOfSunflowers
Copy link
Contributor

Hi all,

#1249 adds a new dependency in requirements.txt but not in setup.py, so dsinternals is not installed when you run pip install impacket for example.

🌻

Closed
@0xdeaddood
Copy link
Collaborator

Oh nice catch! Thanks a lot @ThePirateWhoSmellsOfSunflowers!

@0xdeaddood 0xdeaddood merged commit fb1e50c into fortra:master May 13, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ThePirateWhoSmellsOfSunflowers @0xdeaddood