Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impacket #1434: Added SMB2_FILE_ALLOCATION_INFO type determination, referenced Samba code #1547

Merged
merged 2 commits into from
Jun 27, 2023
Merged

Impacket #1434: Added SMB2_FILE_ALLOCATION_INFO type determination, referenced Samba code #1547

merged 2 commits into from
Jun 27, 2023

Conversation

JerAxxxxxxx
Copy link
Contributor

Added SMB2_FILE_ALLOCATION_INFO type determination, but did not implement anything. The code is based on Samba's smb2_trans2.c

This may solve #1434

@JerAxxxxxxx JerAxxxxxxx changed the title Feat(smbserver): Added SMB2_FILE_ALLOCATION_INFO type determination Impacket #1434: Added SMB2_FILE_ALLOCATION_INFO type determination, referenced Samba code May 9, 2023
@anadrianmanrique anadrianmanrique added bug Unexpected problem or unintended behavior in review This issue or pull request is being analyzed labels May 18, 2023
alexisbalbachan
alexisbalbachan approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@alexisbalbachan alexisbalbachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've suggested a warning message to indicate that the feature is not implemented even though the command succeeded.

impacket/smbserver.py Show resolved Hide resolved
@alexisbalbachan alexisbalbachan merged commit 1df3490 into fortra:master Jun 27, 2023
@0xdeaddood 0xdeaddood removed the in review This issue or pull request is being analyzed label Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexisbalbachan alexisbalbachan alexisbalbachan approved these changes

Assignees

@alexisbalbachan alexisbalbachan

Labels
bug Unexpected problem or unintended behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JerAxxxxxxx @alexisbalbachan @0xdeaddood @anadrianmanrique