Implement better windows os enumeration with checking the build version #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 14, 2024
anadrianmanrique
added
the
in review
|
Closing as this was merged with: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will use the provided build number to better detect possible versions of windows OS. Tho there are sometimes two OS versions (Home users and Server versions) for one build number it still narrows down the actual OS version. If it can't find a matching build version it will display the version number in the old style ("Windows <major_version>.<minor_version> Build <build_number>)
This is only applicable to SMBv2 and SMBv3 as SMBv1 already provides the OS as plaintext in the SMB handshake.
Before and after example:
