Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug(parser): multiline scope registration assigns end of line not start of line as scope start #217

Closed
gnikit opened this issue Nov 1, 2022 · 0 comments · Fixed by #213
Closed

bug(parser): multiline scope registration assigns end of line not start of line as scope start #217

gnikit opened this issue Nov 1, 2022 · 0 comments · Fixed by #213
Assignees
@gnikit

Comments

@gnikit
Copy link
Member

gnikit commented Nov 1, 2022

During parsing the line_no is advanced to the end of the multi-line (&) number, hence when objects are registered in the AST, the scope start is set to the end of the multi-line not the start.

This superficially solved #59

Originally posted by @gnikit in #59 (comment)
@gnikit gnikit self-assigned this Nov 1, 2022
gnikit added a commit that referenced this issue Nov 1, 2022
@gnikit
fix(parser): scope start for line continuation (&)
bd655e4 
Fixes bug(parser): multiline scope registration assigns end of line not start of line as scope start #217
@gnikit gnikit mentioned this issue Nov 1, 2022
Merged
2 tasks
gnikit added a commit that referenced this issue Nov 1, 2022
@gnikit
fix(parser): scope start for line continuation (&)
5cc848f 
Fixes bug(parser): multiline scope registration assigns end of line not start of line as scope start #217
@gnikit gnikit mentioned this issue Nov 1, 2022
Closed
gnikit added a commit that referenced this issue Nov 1, 2022
@gnikit
fix(parser): scope start for line continuation (&)
cca7c73 
Fixes bug(parser): multiline scope registration assigns end of line not start of line as scope start #217
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gnikit gnikit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Change hover to use MarkupContent fortran-lang/fortls
1 participant
@gnikit