Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Modern Fortran throws an error when typing submodule() #233

Closed
1 task done
zoziha opened this issue Aug 10, 2022 · 3 comments · Fixed by #234
Closed
1 task done

bug: Modern Fortran throws an error when typing submodule() #233

zoziha opened this issue Aug 10, 2022 · 3 comments · Fixed by #234
Assignees
@gnikit
Labels
bug Something isn't working

Comments

@zoziha
Copy link

zoziha commented Aug 10, 2022 •
edited
Loading

Is there an existing issue for this?

  • I have searched the existing issues

Description

When entering submodule(), Modern Fortran will report an error, as shown in the following figure:
(This doesn't seem to be that serious, if I ignore it and keep typing the code, everything works fine in Modern Fortran.)

fortran

Screenshots

image

Change request failed for file 
'C:\Users\zoziha\com.zoziha\fortran\tmp\demo\app\demo.f90': Error during parsing

Expected Behaviour

Type submodule() and Modern Fortran will not report an error.

Version of Modern Fortran

v3.2.0

Version of Visual Studio Code

v1.70.0

Platform and Architecture

Windows

Additional Information

Thank you so much for maintaining Modern Fortran, @gnikit ! ❤
@zoziha zoziha added the bug Something isn't working label Aug 10, 2022
@gnikit
Copy link
Member

gnikit commented Aug 10, 2022

Hey @zoziha what version of fortls are you using?

Also could you paste your Modern Fortran settings? I will have a look.

@gnikit gnikit self-assigned this Aug 10, 2022
@zoziha
Copy link
Author

zoziha commented Aug 11, 2022

Thank you for your reply :)

The version of fortls is 2.12.0. I tried the default Modern Fortran and fortls settings, and this error will also appear.

Actually, this problem has existed since I started using VSCode and older versions of Modern Fortran (< v3.0.0) and fortls (hansec/fortran-language-server) 2 years ago.

@gnikit gnikit transferred this issue from fortran-lang/vscode-fortran-support Nov 13, 2022
@gnikit
Copy link
Member

gnikit commented Nov 13, 2022

Apologies @zoziha for taking some time to get to this. This was actually a cluster of bugs that I have since fixed.

gnikit added a commit that referenced this issue Nov 13, 2022
@gnikit
bug: incomplete submodule setting name to None
29ad922 
The submodule AST node was setting the name of the
object to None instead of an empty string which caused
havoc in all sorts of places.

Fixes #233
@gnikit gnikit mentioned this issue Nov 13, 2022
Merged
gnikit added a commit that referenced this issue Nov 14, 2022
@gnikit
test: add parser test for submodule Issue #233
0dbfd3c
gnikit added a commit that referenced this issue Nov 14, 2022
@gnikit
bug: incomplete submodule setting name to None
6f473d3 
The submodule AST node was setting the name of the
object to None instead of an empty string which caused
havoc in all sorts of places.

Fixes #233
gnikit added a commit that referenced this issue Nov 14, 2022
@gnikit
test: add parser test for submodule Issue #233
709622d
gnikit added a commit that referenced this issue Nov 14, 2022
@gnikit
test: add parser test for submodule Issue #233
2e81572
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gnikit gnikit

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bug: incomplete submodule setting name to None fortran-lang/fortls
2 participants
@gnikit @zoziha