Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gnikit/issue106 #110

Merged
merged 9 commits into from
May 10, 2022
Merged

Gnikit/issue106 #110

merged 9 commits into from
May 10, 2022

Conversation

gnikit
Copy link
Member

@gnikit gnikit commented May 10, 2022

Adds pre-commit to fortls

Will check for

  • black
  • isort
  • bad practices (pyupgrade)
  • common pre-commit hooks (EOL, trailing whitespace, etc.)

@gnikit gnikit added this to the v2.5.0 - Backlog milestone May 10, 2022
@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #110 (50b370d) into master (c7c3a76) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #110      +/-   ##
==========================================
+ Coverage   84.95%   84.97%   +0.02%     
==========================================
  Files          11       11              
  Lines        4374     4374              
==========================================
+ Hits         3716     3717       +1     
+ Misses        658      657       -1     
Impacted Files Coverage Δ
fortls/helper_functions.py 91.26% <100.00%> (ø)
fortls/objects.py 81.81% <100.00%> (+0.07%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@gnikit gnikit linked an issue May 10, 2022 that may be closed by this pull request
@gnikit gnikit merged commit c986bb4 into master May 10, 2022
@gnikit gnikit deleted the gnikit/issue106 branch May 10, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add pre-commit
1 participant