-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mention eglot for emacs support #129
Conversation
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
=======================================
Coverage 86.00% 86.00%
=======================================
Files 11 11
Lines 4430 4430
=======================================
Hits 3810 3810
Misses 620 620 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, a few things:
- Multiple plugins should preferably be in their own subsection see the Vim section (the Atom section is not a good example since my extension it is a WIP)
- All the necessary instructions on how to configure
fortls
with eglot should be provided so users can copy-paste them in their configs. It is important to set reasonable options in the config. - I don't know how eglot works or if it downloads the server for you but their README link to
fortls
is wrong, it is pointing to thefortran-language-server
project not this repo.
Ok, I will update the pull request tonight. Regarding the wrong link please see joaotavora/eglot#965, hopefully this will be updated soon. Last but not least: if in f90 mode, eglot will start fortls as default, so no copy and paste required :-) |
Ok, I updated the pull request. Unfortunately, nothing has happend regarding joaotavora/eglot#965 yet. |
Any news on this @ssnnoo ? |
Hi, I changed the commit as requested a while ago and it should be fine now (hopefully). One thing that did not happen is that joaotavora/eglot#965 got merged. But this is completely independent of this contribution here :-) |
The problem is that the underlying extension is pointing to the wrong server, which leads to confusion from the user's perspective. I will go drop a comment |
Sure, I agree. But this is only in the readme, in the source code it only refers to fortls.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @ssnnoo
eglot is a popular lsp client for emacs that supports fortls.