Resolve glob errors in cmd #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #142 1. Changes the container of `incl_suffixes` from a list to a set 2. Also, now the following options defined in the cmd interface will not be initialised to empty sets when a json config file is present. - `excl_paths` - `source_dirs` - `incl_suffixes` - `excl_suffixes` - `include_dirs` Fixes #143
gnikit
force-pushed
the
bug/resolve-globs-cmd
branch
from
06b9321 to
4624a35
Compare
Codecov Report
@@ Coverage Diff @@
## master #144 +/- ##
==========================================
+ Coverage 85.99% 86.01% +0.02%
==========================================
Files 11 11
Lines 4419 4427 +8
==========================================
+ Hits 3800 3808 +8
Misses 619 619
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #142
Fixes #143