fix: len and kind attribute mistaken as variables #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should help distinguish between attributes, variables and functions using that name.
Codecov Report
@@ Coverage Diff @@
## master #238 +/- ##
=======================================
Coverage 86.43% 86.43%
=======================================
Files 12 12
Lines 4474 4475 +1
=======================================
+ Hits 3867 3868 +1
Misses 607 607
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There were some issues with multiprocessing and incorrect coverage reports being reported locally. Restricting the minimum versions should solve this issue.
[skip ci]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preliminary work on parsing attributes such as kind, len
as separate variables in the AST node.
They can then be excluded from the dublication check
for diagnostics.
Fixes #173
Fixes #175