Preprocessor macro expansion #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #368 +/- ##
==========================================
+ Coverage 87.52% 87.65% +0.13%
==========================================
Files 35 35
Lines 4760 4787 +27
==========================================
+ Hits 4166 4196 +30
+ Misses 594 591 -3 ☔ View full report in Codecov by Sentry. |
gnikit
force-pushed
the
feat/generic-macro-expansions
branch
from
f02e58b to
d0d8a20
Compare
for more information, see https://pre-commit.ci
This test is problematic for a few reasons and is in need of refactoring. A summary of the issues are: - macro expansions are already covered in another test - test too big - it pollutes the global workspace of symbols - names of objects are too generic - tests indirectly the preprocessor Its purpose in this PR is to test the preprocessor REGEX patterns work with leading whitespaces and can perform macro expansions. I have opted to remove and write a more compact test.
gnikit
force-pushed
the
feat/generic-macro-expansions
branch
from
d0d8a20 to
c805615
Compare
We don't actually do the full C expansion, as it can be seen by the C-style comment character still present in the output, but it's better than no expansion at all.
gnikit
force-pushed
the
feat/generic-macro-expansions
branch
from
14fb8c8 to
b2e74ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit of the existing open PR #350, addressing review comments and reducing the size of the test case.