fix: not treat form feed as line break (#443) #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gnikit I see "Some checks were not successful" message. If there are anything I should do, please let me know. Thank you for your time! |
|
Hey @tomoto I am rebasing your branch, and let's see what the checks show now. I'll have a look at the PR a bit later. |
gnikit
force-pushed
the
fix/form-feed-issue
branch
from
0998931 to
ed52bc1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #444 +/- ##
==========================================
+ Coverage 88.19% 88.26% +0.06%
==========================================
Files 35 35
Lines 4795 4797 +2
==========================================
+ Hits 4229 4234 +5
+ Misses 566 563 -3 ☔ View full report in Codecov by Sentry. |
|
Thank you! Please take your time :) |
gnikit
force-pushed
the
fix/form-feed-issue
branch
from
ed52bc1 to
92e5d7a
Compare
gnikit
approved these changes
Mar 1, 2025
|
This should now be available in v3.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the suggested fix for issue #443. Please see it for the exact description about what this fix is trying to address.
The issue is caused by splitting the code into lines using
str.splitlinesbuilt-in function, which has a different set of line separators than the editors. (See https://docs.python.org/3/library/stdtypes.html#str.splitlines ) This fix is using our ownsplitlinesfunction instead to make the line separation rule more consistent with the editors.Now fortls can return the correct information regardless of the form feed characters in the code.
