fix: flip the condition in strip_comment for fixed format #448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnikit
force-pushed
the
fix/strip-comment-for-fixed-format
branch
from
9e609b1 to
839b39a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #448 +/- ##
==========================================
+ Coverage 88.17% 88.19% +0.02%
==========================================
Files 35 35
Lines 4795 4795
==========================================
+ Hits 4228 4229 +1
+ Misses 567 566 -1 ☔ View full report in Codecov by Sentry. |
gnikit
approved these changes
Mar 1, 2025
|
This should now be available in v3.2.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the suggested fix for #447. Please see #447 for the exact description about what this fix is trying to address.
As pointed out in the issue above, it looks like a simple mistake in the condition for stripping comments. It works fine as below just by flipping the condition about the OpenMP instruction.