Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New page in quickstart derived types #96

Conversation

smeskos
Copy link
Contributor

@smeskos smeskos commented Jun 5, 2020

A new introductory tutorial about derived types placed as the last page in the Quickstart tutorial.

smeskos added 7 commits June 4, 2020 22:38
1. added gitignore for directory: _site
2. added new link in _data\learing.yml
3. start writing the derived_types.md within learn\quickstart\
1. added all three parts
2. corrected typos
@smeskos
Copy link
Contributor Author

smeskos commented Jun 5, 2020

#build_preview

@github-actions
Copy link

github-actions bot commented Jun 5, 2020

This PR has been built with Jekyll and can be previewed at: https://fortran-lang.org/pr/96/

@LKedward
Copy link
Member

LKedward commented Jun 5, 2020

Hi @smeskos, this is great! Many thanks for adding this. I will go over and review in detail soon 👍

Quick observation: one of your commits seems to modify a lot of files, and I can't work out why?

@milancurcic
Copy link
Member

Thanks a lot, Stavros! This is a great addition.

However, I'm sorry if this wasn't clear (we need to improve the contributing guide): _site/* directory and any files built by Jekyll shouldn't be committed to the repo. They are built and deployed automatically by GitHub.

I think the easiest way to fix this is to close this PR and open a new one which would include only your additions to the Markdown file where the tutorial is, and the associated metadata (.yml).

@LKedward
Copy link
Member

LKedward commented Jun 5, 2020

Ah I see what's happended.

_site/ files are added in 82487ce.
So git revert 82487ce should fix this branch.

@LKedward LKedward mentioned this pull request Jun 5, 2020
@smeskos smeskos closed this Jun 5, 2020
@smeskos
Copy link
Contributor Author

smeskos commented Jun 5, 2020

I will try to fix this.

@smeskos smeskos deleted the new-page-in-quickstart-derived-types branch June 5, 2020 18:47
@LKedward
Copy link
Member

#delete_preview

@github-actions
Copy link

The preview build for this PR has now been deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants