Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of the minibook on building programs: #99

Merged
merged 16 commits into from
Jun 17, 2020

Conversation

arjenmarkus
Copy link
Member

  • Text split into separate "chapters"/"sections"
  • Applying consistent mark-up for code sections and keywords and such
  • Applying most suggestions from the reviews (I have kept the "tabulate.f90"
    mostly as it was, but I have changed the name of the module to make it
    a bit clearer.
  • Small textual changes in places

- Text split into separate "chapters"/"sections"
- Applying consistent mark-up for code sections and keywords and such
- Applying most suggestions from the reviews (I have kept the "tabulate.f90"
  mostly as it was, but I have changed the name of the module to make it
  a bit clearer.
- Small textual changes in places
@milancurcic
Copy link
Member

#build_preview

@github-actions
Copy link

github-actions bot commented Jun 5, 2020

This PR has been built with Jekyll and can be previewed at: https://fortran-lang.org/pr/99/

@milancurcic
Copy link
Member

@arjenmarkus does this PR supersede the previous one (#90)?

@milancurcic
Copy link
Member

@LKedward do you know why this preview didn't build? The preview site doesn't load for me.

@LKedward
Copy link
Member

LKedward commented Jun 5, 2020

@LKedward do you know why this preview didn't build? The preview site doesn't load for me.

It's working for me - can you try on another device, maybe with mobile internet?
I've had this issue before; I think there may be some kind of caching issue with github pages where if you visit the new address too soon, it caches the 404 and keeps serving you with it.

@LKedward
Copy link
Member

LKedward commented Jun 5, 2020

@milancurcic - also give https://fortran-lang.org/pr/99/index.html a try.

@certik
Copy link
Member

certik commented Jun 5, 2020

I think this looks great, thank you.

Once fpm is more usable, we can update the tutorial to show how to do this using fpm.

@arjenmarkus
Copy link
Member Author

arjenmarkus commented Jun 5, 2020 via email

Copy link
Member

@milancurcic milancurcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arjenmarkus Thanks a lot. I love your writing style. I left several minor suggestions.

I noticed that many code listings/snippets are entirely indented by 4 or 8 spaces. Are these indentations necessary?

learn/building_programs/build_tools.md Outdated Show resolved Hide resolved
learn/building_programs/build_tools.md Outdated Show resolved Hide resolved
learn/building_programs/build_tools.md Outdated Show resolved Hide resolved
learn/building_programs/distributing.md Outdated Show resolved Hide resolved
2. Distribute a pre-built executable program
3. Distribute static or dynamic libraries that people can use

ad 1.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does ad. 1 (and so on) mean? Perhaps better to explicitly type out each item for each explanation

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I thought this kind of referencing was "universal" - "ad 1" means "look above for a concise description, here is a more extensive explanation". But that may be a neerlandicism ;).

learn/building_programs/linking_pieces.md Outdated Show resolved Hide resolved
learn/building_programs/managing_libraries.md Outdated Show resolved Hide resolved
learn/building_programs/managing_libraries.md Outdated Show resolved Hide resolved
@milancurcic
Copy link
Member

@arjenmarkus As you review the suggestions, click on "Commit suggestion" to automatically incorporate it in this PR, or just "Resolve conversation" to dismiss it.

Copy link
Member

@everythingfunctional everythingfunctional left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good to me. I approve.

Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good to me. Really interesting and esay to follow! Thank you.

Copy link
Member

@LKedward LKedward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Arjen for your work on this - it's looking really good 👍

@arjenmarkus
Copy link
Member Author

arjenmarkus commented Jun 8, 2020 via email

@arjenmarkus
Copy link
Member Author

arjenmarkus commented Jun 8, 2020 via email

arjenmarkus and others added 7 commits June 16, 2020 18:56
Co-authored-by: Milan Curcic <caomaco@gmail.com>
Co-authored-by: Milan Curcic <caomaco@gmail.com>
Co-authored-by: Milan Curcic <caomaco@gmail.com>
Co-authored-by: Milan Curcic <caomaco@gmail.com>
Co-authored-by: Milan Curcic <caomaco@gmail.com>
Co-authored-by: Milan Curcic <caomaco@gmail.com>
Co-authored-by: Milan Curcic <caomaco@gmail.com>
Co-authored-by: Brad Richardson <everythingfunctional@protonmail.com>
@arjenmarkus
Copy link
Member Author

How to resolve this conflict?

@arjenmarkus
Copy link
Member Author

arjenmarkus commented Jun 16, 2020 via email

@LKedward
Copy link
Member

Hi @arjenmarkus, many thanks.
I've resolved the conflict on github - you will need to run git pull on your local copy if you intend to do any more edits in your local copy.
I will update the #build_preview with the latest changes for a final check.

@github-actions
Copy link

This PR has been built with Jekyll and can be previewed at: https://fortran-lang.org/pr/99/

@arjenmarkus
Copy link
Member Author

arjenmarkus commented Jun 17, 2020 via email

@github-actions
Copy link

This PR has been built with Jekyll and can be previewed at: https://fortran-lang.org/pr/99/

Copy link
Member

@milancurcic milancurcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry to delay this further, I spotted just one tiny thing and suggested adding co-authors. Beyond that, it's great to merge, thank you for leading Arjen!

@GS76
Copy link
Member

GS76 commented Jun 17, 2020

Thank you for everything.

arjenmarkus and others added 6 commits June 17, 2020 16:19
To be accurate: Jérémie Vandenplas

Co-authored-by: Milan Curcic <caomaco@gmail.com>
Co-authored-by: Milan Curcic <caomaco@gmail.com>
Co-authored-by: Laurence Kedward <laurence.kedward@bristol.ac.uk>
Co-authored-by: Laurence Kedward <laurence.kedward@bristol.ac.uk>
Co-authored-by: Laurence Kedward <laurence.kedward@bristol.ac.uk>
Co-authored-by: Laurence Kedward <laurence.kedward@bristol.ac.uk>
@arjenmarkus
Copy link
Member Author

arjenmarkus commented Jun 17, 2020 via email

@LKedward
Copy link
Member

Thanks @arjenmarkus - this looks good! Since you're happy with it, I will merge.

@LKedward LKedward merged commit ff66e8e into fortran-lang:master Jun 17, 2020
@LKedward
Copy link
Member

#delete_preview

@github-actions
Copy link

The preview build for this PR has now been deleted.

@arjenmarkus
Copy link
Member Author

arjenmarkus commented Jun 17, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants