-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull request for urbanjost #16
Conversation
Thanks @urbanjost. Thanks for adding the descriptions, however it was decided (see fortran-lang/fpm#34 (comment)) not to include such meta-data directly in the registry but to instead fetch it from each This data is fetched automatically and stored in index.json which is used for this online page; unfortunately the |
Mystery solved. The file passed the tests described in the README.md file but failed when pushed and I could not find a message explaining why. I could see some of the code looked like it defined a description field but it was not working right after trying several syntax tries so commented them out. Makes sense to read them from the individual sites but the description field needs documented, as you mentioned. Hopefully try two will look better. The packages page is very nice. The Fortran Wiki page allows anyone to add package descriptions themselves. I haven't had time to look at the page long enough, but curious how it will be moderated. Thanks!
… On 09/03/2020 4:40 AM Laurence Kedward ***@***.***> wrote:
Thanks @urbanjost https://github.com/urbanjost .
The CI checks are failing due to M_Pixel not having a License field in its fpm.toml file.
Let me know when you've added it and I can rerun the CI checks.
Thanks for adding the descriptions, however it was decided (see fortran-lang/fpm#34 (comment) fortran-lang/fpm#34 (comment) ) not to include such meta-data directly in the registry but to instead fetch it from each fpm.toml file.
This data is fetched automatically and stored in index.json https://github.com/fortran-lang/fpm-registry/blob/master/index.json which is used for this online page https://fortran-lang.org/packages/fpm ; unfortunately the description field isn't documented so no package currently in the registry defines a description field. If you add a description field to your packages, then it will show up on the website.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub #16 (comment) , or unsubscribe https://github.com/notifications/unsubscribe-auth/AHDWN3JE5VIFVTXZD6UZZYTSD5JADANCNFSM4QT7H6GA .
|
Thanks for the feeback @urbanjost; yes the README should be updated to recommend use of the full validation script ( |
This is now merged and I'm happy to say your packages are displaying nicely on the website with descriptions! Apologies for the small font size of the descriptions, I will increase this. (With descriptions, your fpm packages are also more 'searchable' using the package search box.) |
Thank you for helping straighten that out. Hate to ask for more as you have done so much already, but looking at the general page of packages (not the fpm page per-se) they are binned into "categories"., but the fpm(1) registry is not. When fpm(1) has a search capability would it be useful to have a "category" or "keyword" descriptor as well as "description"? Not only might it be useful for future searches, but might be nice for automatically categorizing the fpm registry page. Not sure if categories should be ignored if they are not part of a predefined list or not. |
I completely agree with you and this is something that I've also been thinking about recently. We loosely look to Rust's package manager I've opened an issue for this here: fortran-lang/fpm#165 |
add to registry from @urbanjost
new packages from @urbanjost -- try2
remove M_draw because getting errors although do not see why
switch M_draw with M_pixel
try all modules including those with C files
removed description comments