Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request for urbanjost #16

Merged
merged 6 commits into from
Sep 4, 2020
Merged

Pull request for urbanjost #16

merged 6 commits into from
Sep 4, 2020

Conversation

urbanjost
Copy link
Contributor

@urbanjost urbanjost commented Sep 2, 2020

add to registry from @urbanjost

new packages from @urbanjost -- try2

remove M_draw because getting errors although do not see why

switch M_draw with M_pixel

try all modules including those with C files

removed description comments

@LKedward
Copy link
Member

LKedward commented Sep 3, 2020

Thanks @urbanjost.
The CI checks are failing due to M_Pixel not having a License field in its fpm.toml file.
Let me know when you've added it and I can rerun the CI checks.

Thanks for adding the descriptions, however it was decided (see fortran-lang/fpm#34 (comment)) not to include such meta-data directly in the registry but to instead fetch it from each fpm.toml file.

This data is fetched automatically and stored in index.json which is used for this online page; unfortunately the description field isn't documented so no package currently in the registry defines a description field. If you add a description field to your packages, then it will show up on the website.

@urbanjost
Copy link
Contributor Author

urbanjost commented Sep 3, 2020 via email

@LKedward LKedward merged commit f437b1d into fortran-lang:master Sep 4, 2020
@LKedward
Copy link
Member

LKedward commented Sep 4, 2020

Thanks for the feeback @urbanjost; yes the README should be updated to recommend use of the full validation script (build_index.py) which actually fetches the individual fpm.toml files.
I will also open issues for the description field in fpm.toml which isn't standard currently.

@LKedward
Copy link
Member

LKedward commented Sep 4, 2020

This is now merged and I'm happy to say your packages are displaying nicely on the website with descriptions! Apologies for the small font size of the descriptions, I will increase this.

(With descriptions, your fpm packages are also more 'searchable' using the package search box.)

@urbanjost urbanjost deleted the urbanjost branch September 4, 2020 21:28
@urbanjost
Copy link
Contributor Author

Thank you for helping straighten that out. Hate to ask for more as you have done so much already, but looking at the general page of packages (not the fpm page per-se) they are binned into "categories"., but the fpm(1) registry is not. When fpm(1) has a search capability would it be useful to have a "category" or "keyword" descriptor as well as "description"? Not only might it be useful for future searches, but might be nice for automatically categorizing the fpm registry page. Not sure if categories should be ignored if they are not part of a predefined list or not.

@LKedward
Copy link
Member

LKedward commented Sep 7, 2020

When fpm(1) has a search capability would it be useful to have a "category" or "keyword" descriptor as well as "description"? Not only might it be useful for future searches, but might be nice for automatically categorizing the fpm registry page. Not sure if categories should be ignored if they are not part of a predefined list or not.

I completely agree with you and this is something that I've also been thinking about recently. We loosely look to Rust's package manager cargo as a good example for how to do things and they do have categories and keywords fields where the former must match predefined 'category slugs' for the particular registry.

I've opened an issue for this here: fortran-lang/fpm#165

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants