Fix compilation with NAG

[awvwgk]

• work around compiler error encountered in NAG for fpm_command_line.f90
• update TOML Fortran to include recursive attribute in serializer
• fix usage of optional argument when not present
• fix error in test suite for namelist IO (see Compiling with NAG fails / binary is not usable #754)
• fix signed integer overflow error in file checksum (see Compiling with NAG fails / binary is not usable #754)
• correctly resolve module duplicates (see Compiling with NAG fails / binary is not usable #754)

Requires

• Fix missing recursive attribute required by NAG toml-f/toml-f#113

See #752 for original NAG report, tracked in #754

[awvwgk]

Test compilation still fails at namelist IO:

cli_test.f90                           failed.
[   5%]Compiling...
NAG Fortran Compiler Release 7.1(Hanzomon) Build 7111
Warning: test/cli_test/cli_test.f90, line 196: Unused dummy variable NAME
Warning: test/cli_test/cli_test.f90, line 250: CMD_BUILD explicitly imported into PARSE but not used
Warning: test/cli_test/cli_test.f90, line 250: CMD_CLEAN explicitly imported into PARSE but not used
Warning: test/cli_test/cli_test.f90, line 250: CMD_INSTALL explicitly imported into PARSE but not used
Warning: test/cli_test/cli_test.f90, line 250: CMD_NEW explicitly imported into PARSE but not used
Warning: test/cli_test/cli_test.f90, line 250: CMD_RUN explicitly imported into PARSE but not used
[NAG Fortran Compiler normal termination, 6 warnings]
test/cli_test/cli_test.f90: In function ‘main_IP_parse’:
test/cli_test/cli_test.f90:246:39: error: ‘host’ undeclared (first use in this function); did you mean ‘cosl’?
 write(lun,nml=act_cli,delim='quote')
                                       ^
                                       cosl
test/cli_test/cli_test.f90:246:39: note: each undeclared identifier is reported only once for each function it appears in

Neither the symbol host nor cosl are present in the current scope or any scope of the file.

[awvwgk]

Runtime error for

fpm run --compiler nagfor -- build
...
Runtime Error: ./src/fpm_sources.f90, line 74: Reference to OPTIONAL argument RECURSE which is not PRESENT
Program terminated by fatal error
./src/fpm_sources.f90, line 74: Error occurred in FPM_SOURCES:ADD_SOURCES_FROM_DIR
./src/fpm.f90, line 131: Called by FPM:BUILD_MODEL
./src/fpm.f90, line 296: Called by FPM:CMD_BUILD
app/main.f90, line 72: Called by MAIN

triggered by this line

fpm/src/fpm_sources.f90

Line 74 in bb44917

call list_files(directory, file_names,recurse=merge(recurse,.true.,present(recurse)))

[awvwgk]

Runtime error due to integer overflow when calculating the file hash

fpm run --compiler nagfor -- build
...
Runtime Error: ./src/fpm_strings.f90, line 198: INTEGER(int64) overflow for 16777619 * 36342609442804091
Program terminated by fatal error
./src/fpm_strings.f90, line 198: Error occurred in FPM_STRINGS:FNV_1A_CHAR
./src/fpm_strings.f90, line 212: Called by FPM_STRINGS:FNV_1A_STRING_T
./src/fpm_source_parsing.f90, line 483: Called by FPM_SOURCE_PARSING:PARSE_C_SOURCE
./src/fpm_sources.f90, line 41: Called by FPM_SOURCES:PARSE_SOURCE
./src/fpm_sources.f90, line 99: Called by FPM_SOURCES:ADD_SOURCES_FROM_DIR
./src/fpm.f90, line 131: Called by FPM:BUILD_MODEL
./src/fpm.f90, line 296: Called by FPM:CMD_BUILD
app/main.f90, line 72: Called by MAIN

I think we actually want an overflow and wrap around here since we are using a signed integer to store a byte sequence.

[awvwgk]

The issue with the integer overflow is an additional check for signed integer overflows. Running in release mode works, except for an error when compiling fpm itself

fpm run --profile release --compiler nagfor -- run
Project is up to date
 Warning: Module test_filesystem in test/fpm_test/test_filesystem.f90 is a duplicate
 Warning: Module test_installer in test/fpm_test/test_installer.f90 is a duplicate
 Warning: Module test_toml in test/fpm_test/test_toml.f90 is a duplicate
 Warning: Module testsuite in test/fpm_test/testsuite.f90 is a duplicate
 Warning: Module test_backend in test/fpm_test/test_backend.f90 is a duplicate
 Warning: Module test_manifest in test/fpm_test/test_manifest.f90 is a duplicate
 Warning: Module test_module_dependencies in test/fpm_test/test_module_dependencies.f90 is a duplicate
 Warning: Module test_package_dependencies in test/fpm_test/test_package_dependencies.f90 is a duplicate
 Warning: Module test_source_parsing in test/fpm_test/test_source_parsing.f90 is a duplicate
 Warning: Module test_versioning in test/fpm_test/test_versioning.f90 is a duplicate
<ERROR>*build_model*:Error: One or more duplicate module names found.
STOP: 1

Looks like the NAG compiled binary fails to correctly resolve the module names.

[awvwgk]

I think this is ready for review now, I collected the unresolved issues in #754 in case anyone wants to have a look at those.

[rouson]

LGTM. Thanks for submitting this @awvwgk !