Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error handling for invalid git dependencies #797

Merged
merged 6 commits into from
Nov 29, 2022
Merged

Improve error handling for invalid git dependencies #797

merged 6 commits into from
Nov 29, 2022

Conversation

minhqdao
Copy link
Contributor

@minhqdao minhqdao commented Nov 18, 2022 •
edited
Loading

Checks for a valid git dependency and improves the error message if the dependency couldn't get resolved.

Tackles #724.

@minhqdao minhqdao changed the title Improve error handling for invalid git dependencies Improve error handling for invalid dependencies Nov 18, 2022
@minhqdao minhqdao changed the title Improve error handling for invalid dependencies Improve error handling for invalid git dependencies Nov 18, 2022
@awvwgk awvwgk added the bug Something isn't working label Nov 18, 2022
@awvwgk awvwgk linked an issue Nov 18, 2022 that may be closed by this pull request
segfaults with invalid dependency #724
Closed
@awvwgk
Copy link
Member

awvwgk commented Nov 18, 2022

Can you add the example from #724 to the unit tests?

awvwgk
awvwgk approved these changes Nov 18, 2022
View reviewed changes
Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing. Looks good to me.

@awvwgk awvwgk requested a review from a team November 18, 2022 16:49
everythingfunctional
everythingfunctional approved these changes Nov 19, 2022
View reviewed changes
Copy link
Member

@everythingfunctional everythingfunctional left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always a fan of improving the error messages. Thanks for the contribution.

@awvwgk awvwgk merged commit b0f55f0 into fortran-lang:main Nov 29, 2022
@minhqdao minhqdao mentioned this pull request Feb 7, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awvwgk awvwgk awvwgk approved these changes

@everythingfunctional everythingfunctional everythingfunctional approved these changes

@certik certik certik approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

segfaults with invalid dependency
4 participants
@minhqdao @awvwgk @certik @everythingfunctional