Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query latest release from GitHub #818

Merged
merged 2 commits into from
Feb 4, 2023

Conversation

perazz
Copy link
Contributor

@perazz perazz commented Dec 27, 2022

This commit modifies the install.sh script such that no manual updating is needed anymore.

The latest published version is queried from GitHub as the latest official package release.

The updated install.sh script queries the latest fpm release version from github directly, instead of having its version hardcoded
@perazz
Copy link
Contributor Author

perazz commented Jan 5, 2023

I believe this is now ready to be merged, but I don't have the rights to ask for any specific reviewer.

CC: @fortran-lang/fpm @certik @everythingfunctional @milancurcic @awvwgk

Copy link
Member

@everythingfunctional everythingfunctional left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it. 👍

Copy link
Member

@milancurcic milancurcic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@perazz
Copy link
Contributor Author

perazz commented Jan 5, 2023

Thank you both!

@perazz perazz closed this Jan 5, 2023
@perazz perazz reopened this Jan 5, 2023
Copy link
Member

@awvwgk awvwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@awvwgk awvwgk merged commit 4be07af into fortran-lang:main Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants