Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple installs #888

Merged
merged 2 commits into from
Apr 25, 2023
Merged

Conversation

perazz
Copy link
Contributor

@perazz perazz commented Apr 24, 2023

Addresses #886. As correctly pointed out there, fpm should never move files away from its internal folders as that will break local storage in unpredictable ways.

I believe usage of move commands was motivated by the fact that, if we want to install a package again in a same folder where it exists already, some OSs may request the user prompt when overwriting files.

I suggest (for install only) to force-copy instead.
cc: @awvwgk @henilp105 @arteevraina @minhqdao @freevryheid @egiovan I'd kindly ask any of you a quick review before merging, thank you in advance.

@perazz
Copy link
Contributor Author

perazz commented Apr 24, 2023

A quick check should be enough on this one. Thank you @minhqdao @arteevraina @henilp105

Copy link
Member

@henilp105 henilp105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @perazz . looks good to me.

@perazz
Copy link
Contributor Author

perazz commented Apr 25, 2023

Thank you @henilp105 @arteevraina, I think I can merge this now.

@perazz perazz merged commit dcb8967 into fortran-lang:main Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants