Skip to content

Adding the preprocessor to the repository? #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aradi opened this issue Jan 30, 2020 · 7 comments
Closed

Adding the preprocessor to the repository? #133

aradi opened this issue Jan 30, 2020 · 7 comments

Comments

@aradi
Copy link
Member

aradi commented Jan 30, 2020

Any views on adding the pre-processor to stdlib? Fypp consists of a single file. If we had it in the repository, the build requirement would reduce to:

  • Fortran compiler
  • CMake
  • Python

All those are quite common, while having Fypp installed on your machine rather not.

@aradi aradi mentioned this issue Jan 30, 2020
@leonfoks
Copy link

If the decision is made to omit the expanded code from the repo, this would be ideal! It would certainly make it easier on the user.

@certik
Copy link
Member

certik commented Jan 30, 2020

It's this file: https://github.com/aradi/fypp/blob/7895a7efb7d2f07dc284cece6cc9474297b8dc55/bin/fypp.

I think that might be fine, to make it easier for people to build.

If the decision is made to omit the expanded code from the repo

Yes, we should not include generated code in the git repository, but rather the release tarball should have the generated code (and thus no Python dependency).

@milancurcic
Copy link
Member

I agree this would ease development. How do you suggest to include it? Commit the script to the repo directly or as a git submodule? The latter would make keeping up to date with upstream easier.

@certik
Copy link
Member

certik commented Jan 30, 2020

I would suggest to commit into the repo directly. The submodules seem to cause more trouble than benefits from my experience.

@jvdp1
Copy link
Member

jvdp1 commented Feb 20, 2020

I would suggest to commit into the repo directly. The submodules seem to cause more trouble than benefits from my experience.

What kind of troubles did you get with submodules?

@certik
Copy link
Member

certik commented Feb 21, 2020

What kind of troubles did you get with submodules?

You have to remember to clone with --recursive, you have to remember how to update, new users have to learn what to do when "git diff" says "dirty", and git clean -dfx does not clean submodules, etc. If possible, I try to avoid them.

@jvdp1
Copy link
Member

jvdp1 commented Feb 21, 2020

You have to remember to clone with --recursive, you have to remember how to update, new users have to learn what to do when "git diff" says "dirty", and git clean -dfx does not clean submodules, etc. If possible, I try to avoid them.

Thank you for your explanations @certik . Then it sounds better to commit it into the repo directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants