-
Notifications
You must be signed in to change notification settings - Fork 187
Adding the preprocessor to the repository? #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
If the decision is made to omit the expanded code from the repo, this would be ideal! It would certainly make it easier on the user. |
It's this file: https://github.com/aradi/fypp/blob/7895a7efb7d2f07dc284cece6cc9474297b8dc55/bin/fypp. I think that might be fine, to make it easier for people to build.
Yes, we should not include generated code in the git repository, but rather the release tarball should have the generated code (and thus no Python dependency). |
I agree this would ease development. How do you suggest to include it? Commit the script to the repo directly or as a git submodule? The latter would make keeping up to date with upstream easier. |
I would suggest to commit into the repo directly. The submodules seem to cause more trouble than benefits from my experience. |
What kind of troubles did you get with submodules? |
You have to remember to clone with |
Thank you for your explanations @certik . Then it sounds better to commit it into the repo directly. |
Any views on adding the pre-processor to stdlib? Fypp consists of a single file. If we had it in the repository, the build requirement would reduce to:
All those are quite common, while having Fypp installed on your machine rather not.
The text was updated successfully, but these errors were encountered: