Skip to content

Use distinct file names #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 10, 2020
Merged

Use distinct file names #267

merged 2 commits into from
Dec 10, 2020

Conversation

certik
Copy link
Member

@certik certik commented Dec 10, 2020

This seems to avoid a filename race conditions on macOS.

Fixes #264.

This seems to avoid a filename race conditions on macOS.

Fixes fortran-lang#264.
@certik
Copy link
Member Author

certik commented Dec 10, 2020

The actual problem seems to be that the ctest tests are executed in parallel, and the tests in test_stdlib_bitset_64 and in test_stdlib_bitset_large where both reading/writing to test.txt. That is definitely a bug, that was fixed.

However, even after renaming the test file in test_stdlib_bitset_large, the test test_stdlib_bitset_64 failed, even though I didn't find another test that would be writing to test.txt. I don't have an explanation for this. But I renamed the test.txt in test_stdlib_bitset_64 also and that seemed to fix the problem.

@certik
Copy link
Member Author

certik commented Dec 10, 2020

I am going to merge this, as this seems to fix it. We will watch the master and see.

@certik certik merged commit 7b24642 into fortran-lang:master Dec 10, 2020
@certik certik deleted the macos_fix branch December 10, 2020 20:21
@certik certik mentioned this pull request Dec 10, 2020
@jvdp1
Copy link
Member

jvdp1 commented Dec 10, 2020

Thank you. Hopefully it is fixed indeed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failure on macOS in master
2 participants