-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes issue with rvs_normal
where it lacks the elemental property
#665
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After reading the code again, I wonder if this function could be elemental
. For example, if an array v(2)
is passed as argument, will the function provided the same result if result(2)
is computed before result(1)
, instead of computing result(1)
before result(2)
? I don't think that the standard implies any order of the computations.
I think it's just a matter of batch calling the function over an array without having to deal with But I can see there is a problem with reproducible "randomness": if the order of the computations is changed (by doing it in parallel it's known that it happens), and since it depends on some stateful routines (there are some variables with the |
Indeed, I refered to the problem of reproducible randomness. I agree with you that it won't affect the generated distribution. The specs should be adapted to reflect these changes too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
Thank you. I will merge it to move further wiuth other PRs. |
As noted in PR#662 there's an error in the demo program given for
rvs_normal
where it lacks the shown elemental property.