Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLAS, LAPACK: Refactor comments for FORD compatibility #786

Merged
merged 3 commits into from
Apr 3, 2024

Conversation

perazz
Copy link
Contributor

@perazz perazz commented Apr 3, 2024

In this PR I've:

  • moved all comment blocks to after interface/subroutine/function
  • removed heading !> NAME: comments that would otherwise be parsed by FORD as commands

FORD can now process all BLAS/LAPACK files properly (tested locally).
However, the process is still lengthy due to the large number of procedure (and ~0.6M lines of code added).
So, I think the idea of PR #784 still applies

Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @perazz for looking at that. I have just a minor comment.

src/stdlib_linalg_blas_aux.fypp Outdated Show resolved Hide resolved
Copy link
Contributor

@gareth-nx gareth-nx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @perazz . IMO this could be merged.

@perazz
Copy link
Contributor Author

perazz commented Apr 3, 2024

Thanks @jvdp1 @gareth-nx for the approvals: I will wait for the checks and then merge, as this is just a cosmetic change.

@perazz perazz merged commit 693986a into fortran-lang:master Apr 3, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants