Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fpm branch: .f90 -> .F90 if preprocessed #787

Merged
merged 1 commit into from
Apr 6, 2024

Conversation

perazz
Copy link
Contributor

@perazz perazz commented Apr 5, 2024

Cf. #772 (comment)
@fortran-lang/stdlib

@perazz
Copy link
Contributor Author

perazz commented Apr 5, 2024

Thanks @jvdp1, let's wait one or two days and merge, if there are no comments.

@perazz perazz merged commit df45374 into fortran-lang:master Apr 6, 2024
17 checks passed
@perazz
Copy link
Contributor Author

perazz commented Apr 6, 2024

Merged.

@jalvesz
Copy link
Contributor

jalvesz commented Apr 9, 2024

This command is not supported in WSL because the system is case insensitive https://superuser.com/questions/1587020/rename-file-on-wsl-using-mv-produced-error-are-the-same-file.

# Capitalize .f90 -> .F90 for preprocessed files
for pp_source in "${preprocessed[@]}"
do 
   mv "$pp_source.f90" "$pp_source.F90" 
done

Now I'm not able to preprocess the files using the shell script as I get:

++ for pp_source in "${preprocessed[@]}"
++ mv stdlib-fpm/src/stdlib_linalg_constants.f90 stdlib-fpm/src/stdlib_linalg_constants.F90
mv: 'stdlib-fpm/src/stdlib_linalg_constants.f90' and 'stdlib-fpm/src/stdlib_linalg_constants.F90' are the same file

[processus terminé avec le code 1 (0x00000001)]

and the process just exits.

Is there a way to either prune the list directly in the first command to then apply twice the fypp command? once for those without preprocessing and once for those with, instead of renaming them afterwards?

Maybe if instead of a shell script, a python script is used it could make things easier? I've just started to apply a similar idea here https://github.com/jalvesz/FSPARSE/blob/main/deployement.py (extremely basic) that I think we could extend here to make an easier fypp preprocessing process and also OS agnostic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants