Fix missing argument to linalg_invert_inplace_ call in linalg_invert_split #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…linalg_invert_split
There is also a typo in line 167: probably not previously catched due to the implicit real<->complex conversion
perazz
approved these changes
Oct 4, 2024
|
Thanks for this fix @cyrilgandon! LGTM |
|
Thank you @cyrilgandon. With 3 approvals, I will merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the fix of
unused-dummy-argumentin #879, I see this case where the pivot argument is not used, but it seems it should be definitely be passed to the linalg_invert_inplace function.I made a different PR since it is no longer a refactoring but a real fix.