-
Notifications
You must be signed in to change notification settings - Fork 197
intrinsics module with alternative implementations #915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
One philosophical question: should the fsum interface be renamed to Regarding the kahan versions, given that the accuracy gains are close between the pure chunked version and the kahan one, I'm wondering which level of support should be enabled to switch between them? |
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
perazz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…and complex types
Co-authored-by: Federico Perini <federico.perini@gmail.com>
Co-authored-by: Federico Perini <federico.perini@gmail.com>
Co-authored-by: Federico Perini <federico.perini@gmail.com>
Co-authored-by: Federico Perini <federico.perini@gmail.com>
Co-authored-by: Federico Perini <federico.perini@gmail.com>
Co-authored-by: Federico Perini <federico.perini@gmail.com>
Co-authored-by: Federico Perini <federico.perini@gmail.com>
Co-authored-by: Federico Perini <federico.perini@gmail.com>
Co-authored-by: Federico Perini <federico.perini@gmail.com>
perazz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @jalvesz. I've adjusted the description of the kahan versions, that do not support integer in the final revision. Great addition!
|
Thanks @perazz I guess I pushed the changes before checking online that you had made the changes as well 😅 the same modifications are ready in the last commit |
jvdp1
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. It can be merged pending a few very minor changes.
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
Co-authored-by: Jeremie Vandenplas <jeremie.vandenplas@gmail.com>
Add intrinsics module containing replacements for intrinsic function where some feature is found interesting: faster implementation, better accuracy, both simultaneously.
This PR follows the discussion in discourse https://fortran-lang.discourse.group/t/lfortran-now-supports-all-intrinsic-functions/8844/41 and it's based on https://github.com/jalvesz/fast_math
stdlib_sumandstdlib_sum_kahan)stdlib_dot_productandstdlib_dot_product_kahan)cc: @fortran-lang/stdlib @perazz @certik @jvdp1