Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for JUnit.xml #42

Merged
merged 2 commits into from
Sep 8, 2024
Merged

Add support for JUnit.xml #42

merged 2 commits into from
Sep 8, 2024

Conversation

awvwgk
Copy link
Member

@awvwgk awvwgk commented Sep 7, 2024 •
edited
Loading

  • add optional JUnit output type for collecting test data
  • ensure xml strings are always printable (no unclosed tags)
  • update JUnit.xml file after every test suite

Closes #35
Closes #27
Closes #26

@awvwgk awvwgk requested a review from jvdp1 September 7, 2024 21:27
This was referenced Sep 7, 2024
Closed
Closed
jvdp1
jvdp1 reviewed Sep 8, 2024
View reviewed changes
Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @awvwgk for this PR. LGTM, except for a critical section in a pure procedure.

src/testdrive.F90 Show resolved Hide resolved
@awvwgk awvwgk requested a review from jvdp1 September 8, 2024 13:33
jvdp1
jvdp1 approved these changes Sep 8, 2024
View reviewed changes
Copy link
Member

@jvdp1 jvdp1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @awvwgk . LGTM. I tested it with Gitlab with different scenarios and it provided the expected JUnit output.

@awvwgk awvwgk merged commit 97b848b into fortran-lang:main Sep 8, 2024
10 checks passed
@awvwgk awvwgk deleted the junit branch September 8, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jvdp1 jvdp1 jvdp1 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Test output as JUnit.xml.
2 participants
@awvwgk @jvdp1