Skip to content

Feature/general improvements #244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 45 commits into from
Oct 20, 2021
Merged

Feature/general improvements #244

merged 45 commits into from
Oct 20, 2021

Conversation

gnikit
Copy link
Member

@gnikit gnikit commented Jun 30, 2021

This PR includes general improvements to the extension.

  1. It updates CHANGELOG versions vs the GitHub releases and updates README
  2. It fixes almost all syntax highlighting bugs
  3. Adds a workflow for publishing to VS Marketplace when a GitHub release happens

Details

TODO:

  • @krvajal to upload the personal access token for VS Marketplace publishing with github name should much that of the publish.yml (VS_MARKETPLACE_TOKEN)

Outstanding problems (currently wontfix)

  1. The OpenACC unittest does not seem to recognise any of the openacc scopes (see .snap file). I have raised this issue to .snap files using scope injections only display results from a single scope PanAeon/vscode-tmgrammar-test#29 but that shouldn't stop us from merging.

@gnikit gnikit marked this pull request as draft June 30, 2021 22:48
@gnikit gnikit self-assigned this Jun 30, 2021
@gnikit gnikit force-pushed the feature/general-improvements branch 4 times, most recently from 73a7707 to 5d53fd2 Compare July 1, 2021 15:54
@gnikit gnikit mentioned this pull request Jul 23, 2021
@gnikit gnikit force-pushed the feature/general-improvements branch from 3f7ce06 to 4b964b3 Compare September 16, 2021 06:54
- The file structures have been updated to abide with the latest config syntax
- Updated build commands in package.json
- Deleted tasks.json.old
Regenerated npm and yarn .json files
The OpenMP regex did not allow for the OpenACC syntax scope to trigger.
This has now been fixed and both should be displayed correctly.

The only outstanding problem is that the unittest (.snap) does not
trigger the right scopes, which means open acc/openmp are not
tested thoroughly. I look into it
@gnikit gnikit requested a review from krvajal September 16, 2021 09:00
@gnikit gnikit marked this pull request as ready for review September 16, 2021 09:00
@gnikit gnikit linked an issue Sep 18, 2021 that may be closed by this pull request
Changes all fortls instances with global variable
and makes pip install user based with upgrade.
gnikit added 3 commits October 1, 2021 19:44
Having preceding characters to ``` caused a problem in the hover result
- Adds support for all Fortran supported logical preprocessor operators
- Adds support for arithmetic operators
- Adds support for C++ preprocessor integers
- Changes the syntax highlighting of preprocessor commands to use the
   `meta` scope which should result in consistent coloring between
   C++ and Fortran. A few things are not supported like macro function
   argument highlighting but I do not believe it is important for now
…n" or "procedure" #207

I have used non-fixed width ngative lookbehinds which should not
 be permitted in traditional Oniguruma regex. VSCode's implementation of
 the regex engine does not seem to care hence the solution
also extends the support for pfunit.

Not sure if .pf and .fpp are considered to be fixed-form by default
I don't think that is the case but fypp and pfunit use them so we
default them to free-form
This is meant to make debugging syntax highlighting bugs easier to trace

The unittests are also updated to contain the new scope names.
Labels were only captured at the start and end of a statement.
Now we are also capturing them in between for if conditionals.

 The edits in the end in "named-control-constructs" are meant to
 correctly handle whitespaces which before they were placed as part of
 the group returned to the invalid.error.xxx

 A unittest has been added testing the conditionals with/out labels.
@gnikit gnikit linked an issue Oct 11, 2021 that may be closed by this pull request
`stop` can now handle labels
@gnikit gnikit linked an issue Oct 11, 2021 that may be closed by this pull request
Fixes Erroneous syntax highlighting with type,abstract :: var #262
A unittest has been added and the CHANGELOG has been updated.
Also updates the tests to use strictEqual
Adds production, test and dev tscofig compilation

Fixes Migrate from vscode module #263
@gnikit gnikit linked an issue Oct 15, 2021 that may be closed by this pull request
Release a tag after token is uploaded
External extensions are enabled since we need the C++ extension
for VSCode to launch without throwing an error.
The tasks.json has been updated to call directly scripts from package.
@krvajal krvajal merged commit 705a918 into master Oct 20, 2021
@gnikit gnikit deleted the feature/general-improvements branch November 9, 2021 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment