Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password not strong enough #13

Closed
planetahuevo opened this issue Feb 24, 2020 · 9 comments
Closed

Password not strong enough #13

planetahuevo opened this issue Feb 24, 2020 · 9 comments

Comments

@planetahuevo
Copy link

Not sure how the system try to check if a password is strong or not, but 64 characters with 256bit key autogenerated password should be enough.
But it is not.
I suggest to change the way to check the passwords on the system.

Thanks

@niftylettuce
Copy link
Contributor

That's odd @planetahuevo - we use strength, and it looks like this issue is related. ruffrey/strength#2

@planetahuevo
Copy link
Author

Can you use something like https://github.com/mkopinsky/zxcvbn-php ?
https://lowe.github.io/tryzxcvbn/
It seems that strength has not been updated for a while.

@niftylettuce
Copy link
Contributor

Yeah, was hooking in zxcvbn right now https://github.com/dropbox/zxcvbn

@planetahuevo
Copy link
Author

The one I have linked is the most updated fork, have a look into that one and the issues with a long discussion about that. As far as I know, that one has evolved and it a little different (and better imho).

@niftylettuce
Copy link
Contributor

We don't use PHP

@planetahuevo
Copy link
Author

Oh, that is true. Sorry I forgot that link was for a php project. :)

@niftylettuce
Copy link
Contributor

It's ok - if you find a better JS alternative let me know, I'm going to look into this more before integrating one solution vs. another

@planetahuevo
Copy link
Author

I will,but that one is good enough as far as I know.
In any case, just force people to get 40 characters and you are good to go ;)

@niftylettuce
Copy link
Contributor

Closed via #17 - I will be deploying this in the next release soon.

imgbot bot pushed a commit to pablopunk/forwardemail.net that referenced this issue Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants