Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General improvements #108

Merged
merged 5 commits into from
Jun 4, 2023
Merged

General improvements #108

merged 5 commits into from
Jun 4, 2023

Conversation

TylerVigario
Copy link
Collaborator

@TylerVigario TylerVigario commented Jun 2, 2023 •
edited
Loading

Breaking Change

This PR converts the filenames for i18n to lowercase to match ISO 639-1. This follows our standard for lang and reduces confusion about casing. It only affects users who import language files individually.

Before

import n2words from 'n2words/i18n/EN.js'

After

import n2words from 'n2words/i18n/en.js'

Changes

  • Fix issues with importing individual languages introduced in Clear up compatability #105.
  • Change i18n language filenames to lowercase
  • Drop Node v19
  • Bench.js now automatically detects i18n languages and tests
  • Reduce Benchmark workflow alerts
  • Updates & improvements to linting

@TylerVigario TylerVigario mentioned this pull request Jun 4, 2023
Closed
@TylerVigario TylerVigario marked this pull request as ready for review June 4, 2023 20:08
@TylerVigario TylerVigario merged commit f81e6d5 into forzagreen:master Jun 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@TylerVigario