-
Notifications
You must be signed in to change notification settings - Fork 2
feat(auth): support multiple accounts #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30b36a6 to
d5081e6
Compare
74245bb to
544db88
Compare
Member
|
Lgtm! Thanks @water-sucks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License Agreement
By creating this pull request, I grant the project maintainers an unlimited,
perpetual license to use, modify, and redistribute these contributions under any terms they
choose, including both the AGPLv3 and the Fossorial Commercial license terms. I
represent that I have the right to grant this license for all contributed content.
Description
This adds support for multiple accounts, and does a bunch of refactoring to make this possible.
$HOME/.config/pangolin, in a more standard location. In the future, this can use$XDG_CONFIG_HOME, if set.config.json, controls the log level, log path, and update checks. These can also be set through corresponding env vars, prefaced withPANGOLIN_CLI.accounts.json, is now being used for setting account information/other mutable state pertaining to them, such as the selected organization. All globalviperstate is banished!context.Context, inherited by thecobra.Commandstruct and passed to every function. The client is automatically instantiated with the active client's session token, if set.pangolin select account, can be used to switch the active account.How to test?
pangolin auth login. You should see two accounts when selecting between thempangolin select account. If an OLM client is running, it should be shut down.