refactor: use functions to init cobra commands, flatten cmd structures #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using global variables for Cobra flag values, and separate defaults and clunky getter functions everywhere, set the defaults inside Cobra's flag set itself. This makes handling of values radically simpler. Additionally, this also adds more stringent flag validation before even running the program, and errors are handled more gracefully at the end with a single os.Exit() invocation.
This normalizes error handling to always propagate up until the Run() function, where this will exit with the 1 status code if an error is detected. Before this commit, some unsuccessful attempts and error states resulted in an exit code of 0, which can throw off shell scripts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License Agreement
By creating this pull request, I grant the project maintainers an unlimited, perpetual license to use, modify, and redistribute these contributions under any terms they choose, including both the AGPLv3 and the Fossorial Commercial license terms. I represent that I have the right to grant this license for all contributed content.
Description
This does a few refactors to flatten the structure of the Cobra commands to avoid excessive nesting and globals. It:
possible
rather than using custom closures to mimic this builtin functionality
os.Exit()behavior to theRun()functions when possible, anduses error handling to determine whether or not to exit with a failure code
to run a default command by just copying the command Run() function
How to test?
This is purely a refactoring PR, All functionality should be the same other than the fact that more states (i.e. unsuccessful login, selection, etc.) should now result in unsuccessful exit codes.