Skip to content

config_example.json doesn't seem recent #30

@DennisGaida

Description

@DennisGaida

Describe the Bug

The https://github.com/fosrl/gerbil/blob/main/config_example.json seems to be outdated. ipAddress for example isn't referenced in the https://github.com/fosrl/gerbil/blob/main/README.md, but the CLI Args talks about an example_config.json which doesn't exist.

Environment

To Reproduce

See https://github.com/fosrl/gerbil/blob/main/config_example.json

Expected Behavior

I'd love a full config example to see all best-practices.

  • REMOTE_CONFIG says "URL of the remote config server" - Aren't we talking Pangolin here? Can we say so in the documentation, e.g. "URL of the remote config server (e.g. Pangolin)"?
  • Documentation differs between the CLI args & Environment Variables, probably should be a table with the same explanation and just listing CLI arg & env var
  • reachableAt says "How should the remote server reach Gerbil's API?" or "Endpoint of the HTTP server to tell remote config about" - Are we talking about remote servers as-in newt? Since the documentation and all examples talk about the local address (e.g. "http://gerbil:3004"), this isn't very "remote" to me. Also see above it is called the "remote config server", so I assume we are actually talking about Pangolin here and not newt.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions