Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: prevent to run twice #158

Merged
merged 1 commit into from
Oct 12, 2022
Merged

ci: prevent to run twice #158

merged 1 commit into from
Oct 12, 2022

Conversation

@drupol drupol marked this pull request as draft October 12, 2022 19:38
@drupol drupol force-pushed the ci/fix-pr-building-twice branch 2 times, most recently from 8aa6180 to d047941 Compare October 12, 2022 19:40
@drupol drupol force-pushed the ci/fix-pr-building-twice branch from d047941 to 76c4039 Compare October 12, 2022 19:41
@drupol drupol marked this pull request as ready for review October 12, 2022 19:48
Copy link
Member

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sometimes also use CI when pushing to a branch to avoid local builds before opening a PR as described here open-telemetry/opentelemetry-python#1370 (comment) But for this project, I think most of the changes are sufficiently small so I probably open PRs straight away.

Also, in other projects in the past CI would not run on my PR before someone approved it but it would still run in my fork’s branches. This allowed me to fix possible issues before maintainer got around to allowing the CI on the PR. Again, not sure how relevant it is here.

I guess we can try it out.

@drupol drupol merged commit a2900e4 into master Oct 12, 2022
@drupol drupol deleted the ci/fix-pr-building-twice branch October 12, 2022 20:33
@drupol
Copy link
Collaborator Author

drupol commented Oct 12, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants