-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change texts in the front page of "Call for Speakers" #274
Change texts in the front page of "Call for Speakers" #274
Conversation
Reviewer's Guide by SourceryThis pull request modifies the text displayed on the CFP submission page for non-logged-in users and updates the text on the login and register buttons. The changes aim to improve clarity and user experience. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @hongquan - I've reviewed your changes - here's some feedback:
Overall Comments:
- It looks like you're using
{{ _(...) }}
for translations instead of{% translate ... %}
– is there a reason for this change?
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@sourcery-ai
|
Fix part of #270
One requirement is not done yet: "Button A: Provide an option in the config file to change the login button text."
because the strings in pretalx.cfg file cannot be marked as translatable.
I will work on it in another PR, after find out a solution.
How has this been tested?
Checklist
Summary by Sourcery
Enhancements: