Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change texts in the front page of "Call for Speakers" #274

Conversation

hongquan
Copy link
Member

@hongquan hongquan commented Feb 19, 2025

Fix part of #270

One requirement is not done yet: "Button A: Provide an option in the config file to change the login button text."
because the strings in pretalx.cfg file cannot be marked as translatable.

I will work on it in another PR, after find out a solution.

How has this been tested?

image

Checklist

  • I have added tests to cover my changes.

Summary by Sourcery

Enhancements:

  • Improves the clarity of the text on the "Call for Speakers" front page, including the login and registration prompts.

Copy link

sourcery-ai bot commented Feb 19, 2025

Reviewer's Guide by Sourcery

This pull request modifies the text displayed on the CFP submission page for non-logged-in users and updates the text on the login and register buttons. The changes aim to improve clarity and user experience.

No diagrams generated as the changes look simple and do not need a visual representation.

File-Level Changes

Change Details Files
Updated the text displayed to users who are not logged in when submitting a proposal.
  • Replaced the original text with a more concise and user-friendly message.
  • Improved clarity by specifying the benefits of logging in, such as the ability to edit proposals and check their status.
src/pretalx/cfp/templates/cfp/event/submission_base.html
Modified the text on the login and register buttons.
  • Changed the 'Login with SSO' button text to 'Login'.
  • Changed the 'Register Speaker Account' button text to 'Register account'.
src/pretalx/common/templates/common/auth.html

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!
  • Generate a plan of action for an issue: Comment @sourcery-ai plan on
    an issue to generate a plan of action for it.

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hongquan - I've reviewed your changes - here's some feedback:

Overall Comments:

  • It looks like you're using {{ _(...) }} for translations instead of {% translate ... %} – is there a reason for this change?
Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@hongquan
Copy link
Member Author

@sourcery-ai
I changed from {% translate ... %} to {{ _(...) }} because:

  • The second syntax is shorter, and a recent update of Django.
  • It allow us to migrate from Django Template to Jinja easier (supported by both). This migration will not be done in near future, though.

@mariobehling mariobehling merged commit 2ca2edf into fossasia:development Feb 19, 2025
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants