Remove "Delete My Account" option from Speaker Profile section #1238
+97
−98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's GuideTemporarily disables the “Delete My Account” feature by removing its UI, disabling related routes and URL mappings, and annotating the incomplete deletion logic with TODOs for a future comprehensive implementation. Class diagram for updated DeleteAccountView and related URL mappingclassDiagram
class EventUrls {
+reset
+submit
+user
#user_delete (disabled)
+user_submissions
+user_mails
+schedule
}
class DeleteAccountView {
+post(request, event)
#TODO: Only calls user.deactivate(), does not fully delete user data
}
EventUrls <|-- DeleteAccountView
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- The broad indentation reformat in user_profile.html adds a lot of noise—please restrict changes to only the deletion section to keep the diff focused.
- Instead of commenting out the delete-account code, consider removing it entirely (you can always restore via version control) to keep templates and URL configs clean.
- Rather than hard‐commenting the delete route, you might introduce a feature flag or conditional setting to disable account deletion until the GDPR-compliant implementation is ready.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The broad indentation reformat in user_profile.html adds a lot of noise—please restrict changes to only the deletion section to keep the diff focused.
- Instead of commenting out the delete-account code, consider removing it entirely (you can always restore via version control) to keep templates and URL configs clean.
- Rather than hard‐commenting the delete route, you might introduce a feature flag or conditional setting to disable account deletion until the GDPR-compliant implementation is ready.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Author
|
@mariobehling please take a look when you're free. Thanks! |
Member
|
@jevinjojo Please follow the suggestion of @sourcery-ai about
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR temporarily removes the "Delete My Account" functionality from the speaker profile page until a proper GDPR-compliant account deletion implementation can be developed. The feature is gated behind a feature flag (ENABLE_ACCOUNT_DELETION) that defaults to False.
Key changes:
- Added
ENABLE_ACCOUNT_DELETIONfeature flag in settings (defaults to False) - Conditionally registered the
/me/deleteroute based on feature flag - Removed account deletion UI section from the user profile template
- Commented out
user_deleteURL property in Event model
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| app/eventyay/config/settings.py | Introduces ENABLE_ACCOUNT_DELETION feature flag with default False to control account deletion feature availability |
| app/eventyay/cfp/views/user.py | Adds documentation to DeleteAccountView explaining it's disabled by default and requires GDPR-compliant implementation |
| app/eventyay/cfp/urls.py | Conditionally registers the delete account route only when feature flag is enabled |
| app/eventyay/cfp/templates/cfp/event/user_profile.html | Removes entire account deletion section from the speaker profile UI |
| app/eventyay/base/models/event.py | Comments out user_delete URL property with TODO note about incomplete implementation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
app/eventyay/cfp/views/user.py
Outdated
Comment on lines
427
to
428
| TODO: Current implementation only calls user.deactivate() and does not fully remove user data and | ||
| is not GDPR compliant and will need a complete rework with proper data cleanup, once Account settings feature implemented. |
There was a problem hiding this comment.
The documentation has a grammatical error. The phrase "and does not fully remove user data and is not GDPR compliant" is redundant. It should be either "does not fully remove user data" or "is not GDPR compliant", or better yet: "does not fully remove user data (not GDPR compliant)".
Suggested change
| TODO: Current implementation only calls user.deactivate() and does not fully remove user data and | |
| is not GDPR compliant and will need a complete rework with proper data cleanup, once Account settings feature implemented. | |
| TODO: Current implementation only calls user.deactivate() and does not fully remove user data (not GDPR compliant). | |
| A complete rework with proper data cleanup will be needed once the Account settings feature is implemented. |
app/eventyay/base/models/event.py
Outdated
| submit = '{base}submit/' | ||
| user = '{base}me/' | ||
| user_delete = '{base}me/delete' | ||
| # TODO: Disabled user_delete URL — delete endpoint is incomplete/broken. |
There was a problem hiding this comment.
There's an extra space in the TODO comment. "TODO: Disabled" should be "TODO: Disabled" (single space after colon).
Suggested change
| # TODO: Disabled user_delete URL — delete endpoint is incomplete/broken. | |
| # TODO: Disabled user_delete URL — delete endpoint is incomplete/broken. |
Author
|
@mariobehling I think we're good to go! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Changes Made
user_profile.html/me/deleteroute incfp/urls.pyto prevent API accessDeleteAccountViewexplaining the issueSummary by Sourcery
Temporarily remove the "Delete My Account" option from the speaker profile page and disable its endpoint until a full, GDPR-compliant account deletion feature is implemented.
Enhancements:
Documentation:
Chores: