chore: fixed featured sessions and 500 errors on sessions and reviews #1331
+20
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR enhances the featured sessions UI and fixes server errors by updating CSS and templates for proper alignment and URL handling, refining locale lookups in the Event model, and correcting JS request construction and CSRF header naming. Sequence diagram for toggling featured status with improved URL and CSRF handlingsequenceDiagram
actor User
participant "Session List Page"
participant "JavaScript (main.js)"
participant "Backend Server"
User->>"Session List Page": Loads page
"Session List Page"->>"JavaScript (main.js)": Renders featured checkbox with data-url and correct CSRF token
User->>"JavaScript (main.js)": Clicks featured checkbox
"JavaScript (main.js)"->>"Backend Server": POST to toggle_featured (using data-url, eventyay_csrftoken)
Backend Server-->>"JavaScript (main.js)": Returns status
"JavaScript (main.js)"->>User: Updates UI status
Class diagram for Event model locale lookup changesclassDiagram
class Event {
+available_content_locales() list
+named_content_locales() list
+named_plugin_locales() list
}
class settings {
LANGUAGES
}
class LANGUAGE_NAMES
Event --> settings : uses LANGUAGES
Event --> LANGUAGE_NAMES : uses LANGUAGE_NAMES in named_content_locales
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `app/eventyay/static/orga/css/_layout.css:59-67` </location>
<code_context>
.submission_featured {
position: relative;
text-align: center;
+ vertical-align: middle;
+
+ .form-check {
</code_context>
<issue_to_address>
**suggestion:** Consider if vertical-align is effective for block-level elements.
'vertical-align: middle;' does not work as expected on divs. For vertical centering, consider using flexbox or grid instead.
```suggestion
.submission_featured {
position: relative;
display: flex;
align-items: center;
justify-content: center;
text-align: center;
.form-check {
display: inline-block;
margin: 0;
}
```
</issue_to_address>
### Comment 2
<location> `app/eventyay/base/models/event.py:2118` </location>
<code_context>
@cached_property
def named_content_locales(self) -> list:
locale_names = dict(self.available_content_locales)
# locale_names['en-us'] = locale_names['en']
locale_names.update(LANGUAGE_NAMES)
return [(code, locale_names.get(code, code)) for code in self.content_locales]
</code_context>
<issue_to_address>
**suggestion (code-quality):** Merge dictionary updates via the union operator ([`dict-assign-update-to-union`](https://docs.sourcery.ai/Reference/Default-Rules/suggestions/dict-assign-update-to-union/))
```suggestion
locale_names |= LANGUAGE_NAMES
```
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes featured session functionality and resolves 500 errors occurring on session and review pages by correcting CSRF token references and improving locale handling.
Key Changes:
- Updated CSRF token cookie name from
pretalx_csrftokentoeventyay_csrftokenin JavaScript - Enhanced featured session toggle UI with improved centering and styling
- Modified locale resolution logic to prevent 500 errors when content locales are not found
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/eventyay/static/orga/js/main.js | Updates CSRF token name and adds support for data-url attribute with fallback URL construction for featured toggle requests |
| app/eventyay/static/orga/css/_layout.css | Improves featured checkbox alignment with vertical centering and inline-flex layout |
| app/eventyay/orga/templates/orga/submission/list.html | Adds data-url attribute to featured toggle input and centers the featured column header |
| app/eventyay/base/models/event.py | Changes locale source from default_django_settings.LANGUAGES to settings.LANGUAGES and adds fallback for missing locale names |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| locale_names = dict(self.available_content_locales) | ||
| # locale_names['en-us'] = locale_names['en'] | ||
| return [(code, locale_names[code]) for code in self.content_locales] | ||
| locale_names |= LANGUAGE_NAMES |
There was a problem hiding this comment.
The merge operation locale_names |= LANGUAGE_NAMES is problematic because:
locale_namesis created fromdict(self.available_content_locales)(line 2157)available_content_localesalready usesdict(settings.LANGUAGES)(line 2151)LANGUAGE_NAMESis redefined at line 74 as{code: name for code, name in settings.LANGUAGES}
This means you're merging settings.LANGUAGES back into a dict that was already built from settings.LANGUAGES, making this operation redundant.
The intended behavior appears to be merging the imported LANGUAGE_NAMES from eventyay.common.language (which contains additional language names from settings.LANGUAGES_INFORMATION), but the redefinition at line 74 overwrites that import.
Suggestion: Remove the redefinition at line 74 to use the imported LANGUAGE_NAMES, which contains the enhanced language information from settings.LANGUAGES_INFORMATION.
mariobehling
requested changes
Nov 23, 2025
Member
mariobehling
left a comment
mariobehling
left a comment
There was a problem hiding this comment.
Please check AI comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1291 and solves 500 errors on sessions and review page
Summary by Sourcery
Improve UI and robustness of the featured session toggle and resolve server errors on session and review pages
Bug Fixes:
Enhancements: