-
Notifications
You must be signed in to change notification settings - Fork 148
Delete URL redirection for legacy eventyay-xx websites #1338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete URL redirection for legacy eventyay-xx websites #1338
Conversation
Those URLs are for logged-in users, not for public search. We don't need to keep them alive.
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRemoves legacy eventyay-xx URL redirections and associated helper code, simplifying the main domain URL configuration so legacy paths no longer resolve for logged-in users or public access. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there - I've reviewed your changes - here's some feedback:
- Since the legacy_redirect_patterns and redirects module are removed, double-check maindomain_urlconf.py for any remaining unused imports or helpers that were only referenced from those patterns and clean them up to keep the URL config minimal.
- Now that legacy URL names like
video.legacy.*andtalk.legacy.*are gone, search for any references to those URL names (e.g., in templates or redirects) and remove or update them to avoid runtime reverse resolution errors.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Since the legacy_redirect_patterns and redirects module are removed, double-check maindomain_urlconf.py for any remaining unused imports or helpers that were only referenced from those patterns and clean them up to keep the URL config minimal.
- Now that legacy URL names like `video.legacy.*` and `talk.legacy.*` are gone, search for any references to those URL names (e.g., in templates or redirects) and remove or update them to avoid runtime reverse resolution errors.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes legacy URL redirection functionality that was used for backward compatibility with old eventyay website URLs. These redirects were for logged-in user URLs and are no longer needed.
- Deletes the entire
app/eventyay/multidomain/redirects.pyfile containing legacy redirect view functions - Removes legacy redirect URL patterns and related constants from the URL configuration
- Cleans up the import statement for the now-deleted redirects module
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/eventyay/multidomain/redirects.py | Complete removal of legacy redirect view functions for video and talk URLs |
| app/eventyay/multidomain/maindomain_urlconf.py | Removes import of redirects module, deletes legacy redirect constants and URL patterns, updates comment to reflect removal |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Those URLs are for logged-in users, not for public search. We don't need to keep them alive.
Part of #1243
Summary by Sourcery
Remove support for legacy URL redirections for old eventyay-xx endpoints and simplify the main domain URL configuration.
Enhancements: