Skip to content

Conversation

@hongquan
Copy link
Member

@hongquan hongquan commented Nov 24, 2025

Those URLs are for logged-in users, not for public search. We don't need to keep them alive.

Part of #1243

Summary by Sourcery

Remove support for legacy URL redirections for old eventyay-xx endpoints and simplify the main domain URL configuration.

Enhancements:

  • Drop legacy redirect patterns and associated configuration for old video and event URLs from the main domain routing.
  • Remove the now-unused redirects module related to legacy URL handling.

Those URLs are for logged-in users, not for public search.
We don't need to keep them alive.
@hongquan hongquan requested a review from Copilot November 24, 2025 03:53
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Nov 24, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Removes legacy eventyay-xx URL redirections and associated helper code, simplifying the main domain URL configuration so legacy paths no longer resolve for logged-in users or public access.

File-Level Changes

Change Details Files
Remove legacy URL redirect support for old event/talk/video routes.
  • Deleted EXCLUDED_LEGACY_PREFIXES and MATCHED_LEGACY_SUBPATHS constants and their derived regex helper variables used to detect legacy paths.
  • Removed legacy_redirect_patterns definitions, including routes for /video assets, /video SPA index, /video/<event_identifier> redirects, and generic legacy event/talk redirects based on event slugs.
  • Updated urlpatterns composition to no longer include legacy_redirect_patterns, keeping only common, storage, plugin, presale, and unified event patterns in order.
app/eventyay/multidomain/maindomain_urlconf.py
app/eventyay/multidomain/redirects.py

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Since the legacy_redirect_patterns and redirects module are removed, double-check maindomain_urlconf.py for any remaining unused imports or helpers that were only referenced from those patterns and clean them up to keep the URL config minimal.
  • Now that legacy URL names like video.legacy.* and talk.legacy.* are gone, search for any references to those URL names (e.g., in templates or redirects) and remove or update them to avoid runtime reverse resolution errors.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Since the legacy_redirect_patterns and redirects module are removed, double-check maindomain_urlconf.py for any remaining unused imports or helpers that were only referenced from those patterns and clean them up to keep the URL config minimal.
- Now that legacy URL names like `video.legacy.*` and `talk.legacy.*` are gone, search for any references to those URL names (e.g., in templates or redirects) and remove or update them to avoid runtime reverse resolution errors.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copilot finished reviewing on behalf of hongquan November 24, 2025 03:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes legacy URL redirection functionality that was used for backward compatibility with old eventyay website URLs. These redirects were for logged-in user URLs and are no longer needed.

  • Deletes the entire app/eventyay/multidomain/redirects.py file containing legacy redirect view functions
  • Removes legacy redirect URL patterns and related constants from the URL configuration
  • Cleans up the import statement for the now-deleted redirects module

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
app/eventyay/multidomain/redirects.py Complete removal of legacy redirect view functions for video and talk URLs
app/eventyay/multidomain/maindomain_urlconf.py Removes import of redirects module, deletes legacy redirect constants and URL patterns, updates comment to reflect removal

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mariobehling mariobehling merged commit de46975 into fossasia:enext Nov 24, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants