Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keyboard Control #253

Open
3 of 5 tasks
niccokunzmann opened this issue Jan 12, 2017 · 4 comments
Open
3 of 5 tasks

Keyboard Control #253

niccokunzmann opened this issue Jan 12, 2017 · 4 comments
Labels
enhancement GCI middle

Comments

@niccokunzmann
Copy link
Member

niccokunzmann commented Jan 12, 2017 •
edited
Loading

Allow controlling the Flappy-Game only via Keyboard:

  • change character via space
  • change background via b
  • start the game via ENTER
  • restart the game via space and ENTER when game is over
  • Document this in the how-to
@Marauderer97
Copy link
Collaborator

Marauderer97 commented Jan 12, 2017 •
edited
Loading

@niccokunzmann I would like to work on this :)

@niccokunzmann
Copy link
Member Author

@Marauderer97 sure, please go ahead!

@Marauderer97
Copy link
Collaborator

@niccokunzmann I have implemented the first 3 points. As for the restart, handling two keystrokes at once was giving me trouble, so I used r key to restart the game. I decided to wait for your approval before modifying the how to play svg. :)

@abishekvashok
Copy link
Member

@Marauderer97 pls change the how to play to comply with the changes, we would also like to read your good PRs

Marauderer97 added a commit to Marauderer97/flappy-svg that referenced this issue Jan 13, 2017
@Marauderer97
Fixes fossasia#253 Adds Keyboard Control and updates the how-to-play svg
f42a18f
Marauderer97 added a commit to Marauderer97/flappy-svg that referenced this issue Jan 13, 2017
@Marauderer97
Fixes fossasia#253 Adds Keyboard Control and updates the how-to-play svg
a260518
Marauderer97 added a commit to Marauderer97/flappy-svg that referenced this issue Jan 13, 2017
@Marauderer97
Fixes fossasia#253 Adds Keyboard Control and updates the how-to-play svg
0e16821
Marauderer97 added a commit to Marauderer97/flappy-svg that referenced this issue Jan 13, 2017
@Marauderer97
Fixes fossasia#253 Adds Keyboard Control and updates the how-to-play…
15ec816 
… svg

	Fixes fossasia#253 Adds Keyboard Control and updates the how-to-play svg
@Marauderer97 Marauderer97 mentioned this issue Jan 13, 2017
Merged
Marauderer97 added a commit to Marauderer97/flappy-svg that referenced this issue Jan 13, 2017
@Marauderer97
Merge pull request #1 from Marauderer97/key-control
3c402b5 
Fixes fossasia#253 Adds Keyboard Control and updates the how-to-play svg
Marauderer97 added a commit to Marauderer97/flappy-svg that referenced this issue Jan 13, 2017
@Marauderer97
Revert "Fixes fossasia#253 Adds Keyboard Control and updates the how-…
63aa62c 
…to-play svg"
Marauderer97 added a commit to Marauderer97/flappy-svg that referenced this issue Jan 13, 2017
@Marauderer97
Merge pull request #2 from Marauderer97/revert-1-key-control
7beaba8 
Revert "Fixes fossasia#253 Adds Keyboard Control and updates the how-to-play svg"
niccokunzmann pushed a commit that referenced this issue Jan 13, 2017
@Marauderer97 @niccokunzmann
Fixes #253 Adds Keyboard Control and updates the how-to-play svg (#258)
0c62744 
* Fixes #253 Adds Keyboard Control and updates the how-to-play svg

* Resolving merge conflicts
@niccokunzmann niccokunzmann reopened this Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement GCI middle
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@niccokunzmann @abishekvashok @Marauderer97