Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pagination in SearchResultsFragment #2013

Closed
anhanh11001 opened this issue Jun 26, 2019 · 0 comments · Fixed by #2072
Closed

Add pagination in SearchResultsFragment #2013

anhanh11001 opened this issue Jun 26, 2019 · 0 comments · Fixed by #2072
Labels
feature has-PR Already has a PR and waiting for reviews
Milestone
Milestone 6: Summ...

Comments

@anhanh11001
Copy link
Contributor

Describe the feature you'd like
Add pagination in SearchResultsFragment

Additional context
Should be work upon after #84 is solved

Would you like to work on the issue?
Yes
@anhanh11001 anhanh11001 added this to the Milestone 6: Summer 2019 milestone Jun 27, 2019
@anhanh11001 anhanh11001 added feature has-PR Already has a PR and waiting for reviews and removed has-PR Already has a PR and waiting for reviews labels Jun 27, 2019
@anhanh11001 anhanh11001 mentioned this issue Jul 5, 2019
Merged
iamareebjamal pushed a commit that referenced this issue Jul 5, 2019
@anhanh11001 @iamareebjamal
feat: Add pagination in search (#2072)
7802a0f 
Details:
- Add pagination in search
- Split adapter class between FavoriteFragment and SearchResultsFragment
- Split ViewModel between SearchFragment and SearchResultsFragment

Fixes: #2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature has-PR Already has a PR and waiting for reviews
Projects
None yet
Milestone
Milestone 6: Summer 2019
Development

Successfully merging a pull request may close this issue.

feat: Add pagination in search
1 participant
@anhanh11001