fix: improve payment by stripe #1084
Conversation
1)corrected the keyboard type for input 2)made the whole button clickable in case of the month, year and card type selector 3)added card No. validator and automatic card type selector feat: fossasia#1071
| val visaPattern = Pattern.compile("^4[0-9]{0,15}$") | ||
| val masterCardPattern = Pattern.compile("^(5[1-5]|222[1-9]|22[3-9][0-9]|2[3-6]" + | ||
| "[0-9]{2}|27[01][0-9]|2720)[0-9]{0,15}$") | ||
| val americanExpressPattern = Pattern.compile("^3[47][0-9]{0,15}$") |
There was a problem hiding this comment.
Stripe most probably has pre defined functions to check the above. Can you confirm? if yes use them
There was a problem hiding this comment.
They have their own cardInputwidget which handles all these operation https://stripe.com/docs/mobile/android .
- That would mean changing the whole input section .. should I use it ???
There was a problem hiding this comment.
If that is the case then it is fine
There was a problem hiding this comment.
Can you elaborate is current commit fine or I should use cardInputWidget
There was a problem hiding this comment.
@nikit19 please reply
iamareebjamal
changed the title
|
Please add wip: in title until the work is complete |
Lifted ticketIdAndQty from view layer to viewModel and done required changes feat: fossasia#1097
pranavpandey1998official
changed the title
pranavpandey1998official
changed the title
pranavpandey1998official
changed the title
|
@iamareebjamal, please review and merge it |
iamareebjamal
changed the title
|
Fix conflicts |
pranavpandey1998official
force-pushed
the
spripe
branch
from
94aa3ce to
089ef8f
Compare
pranavpandey1998official
force-pushed
the
spripe
branch
from
635fcdd to
94cc3c0
Compare
|
@iamareebjamal done |
| cardBrand = attendeeViewModel.cardType[0] | ||
| selectCardText.text = cardBrand | ||
| rootView.cardSelector.isVisible = true | ||
| rootView.cardNumber.error = "Invalid card number" |
There was a problem hiding this comment.
Move logic to a util and remove duplication
app/src/main/java/org/fossasia/openevent/general/attendees/AttendeeFragment.kt
Show resolved
Hide resolved
| @@ -131,4 +132,17 @@ object Utils { | |||
| navigation.animation = AnimationUtils.loadAnimation(context, R.anim.slide_down) | |||
| } | |||
| } | |||
|
|
|||
| fun creditCardVerify(s: String): Int { | |||
There was a problem hiding this comment.
Name properly and return enum
There was a problem hiding this comment.
done
1)corrected the keyboard type for input 2)made the whole button clickable in case of the month, year and card type selector 3)added card No. validator and automatic card type selector feat: fossasia#1071
pranavpandey1998official
force-pushed
the
spripe
branch
from
71fe3b0 to
082b43f
Compare
|
@pranavpandey1998official Updates? |
|
@iamareebjamal I have introduced an enum as you said and removed all unnecessary changes. what next? |
|
Go to File changes and see the requested changes |
pranavpandey1998official
force-pushed
the
spripe
branch
from
c19815b to
14228f8
Compare
|
There are still unrelated changes. Please revert them. |
|
@iamareebjamal the indentation changes are done through gradlew spotlessApply , if i revert them gradlew spotlessCheck is failing and rest are changes are related to commit please specify if you find something else |
1)corrected the keyboard type for input
2)made the whole button clickable in case of the month, year and card type selector
3)added card No. validator and automatic card type selector
feat: #1071
