fix: Remove extra space in settings. #1108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angmas1
changed the title
|
@iamareebjamal @nikit19 Please review. |
|
We used takisoft so that preferences look same in KitKat as well. Please check how does it look there |
|
Okay. Will post a screenshot |
|
Just tried running the app on API 19 (Kitkat) and found out that the current development branch of app(not the one associated with this pull request) crashes on kitkat. Should I open an issue for that? @iamareebjamal |
|
Yes |
iamareebjamal
approved these changes
Mar 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #873
Changes: Updated library to google's preference library with fix for bug that didn't let app:iconSpaceReserved to get applied to PreferenceCategory. For more info visit: https://issuetracker.google.com/issues/111662669#comment19
Screenshots for the change:
