feat: Added empty view for events fragment #1157
Conversation
| import kotlinx.android.synthetic.main.fragment_events.view.progressBar | ||
| import kotlinx.android.synthetic.main.fragment_events.view.shimmerEvents | ||
| import kotlinx.android.synthetic.main.fragment_events.view.swiperefresh | ||
| import kotlinx.android.synthetic.main.fragment_events.view.* |
| android:layout_height="450dp" | ||
| android:text="@string/no_events_message" | ||
| android:gravity="center" | ||
| /> |
| <TextView | ||
| android:id="@+id/noEventsMessage" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="450dp" |
There was a problem hiding this comment.
Please define all dimensions in dimension resources file.
There was a problem hiding this comment.
I will fix it now
There was a problem hiding this comment.
I fixed it, please review
| import kotlinx.android.synthetic.main.fragment_events.view.progressBar | ||
| import kotlinx.android.synthetic.main.fragment_events.view.shimmerEvents | ||
| import kotlinx.android.synthetic.main.fragment_events.view.homeScreenLL | ||
| import kotlinx.android.synthetic.main.fragment_events.view.locationTextView |
There was a problem hiding this comment.
sorry for that, I will make sure I learn how to check for difference of files carefully before making a push and PR, I fixed that
…nhanh11001/open-event-android into 1141_empty_view_event_fragment
| <TextView | ||
| android:id="@+id/noEventsMessage" | ||
| android:layout_width="match_parent" | ||
| android:layout_height="@dimen/empty_view_height" |
There was a problem hiding this comment.
@iamareebjamal please review again, I've made my change, I was having problem to make the empty-event message in the center of screen, but then I figured out that the NestedScrollView doesn't fill up the screen when there are no enough data. So I put the fillViewPort="true" in.
|
@liveHarshit please review when you have the time |
Fixes #1141 Adding empty view for EventsFragment
Screenshots for the change:
